[Freeciv-Dev] Re: (PR#10113) genlist_unlink_all bug

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10113 >

Jason Short wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=10113 >
> 
> Apparently nobody uses genlist_unlink_all.  There's a bug because of a 
> missing NULL check.

Sorry, the bug is in genlist_unlink not genlist_unlink_all.  It only 
happens if you unlink an element that's in the list.  While allowed, 
this is probably not what you want to be doing.  It occurrs if you try 
to connect twice to a server with the same username.

jason