[Freeciv-Dev] Re: (PR#10052) Apollo & Marco Polo work even when they should be obsolete

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10052 >

Marko Lindqvist wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=10052 >
> 
> Jason Short wrote:
> 
>><URL: http://rt.freeciv.org/Ticket/Display.html?id=10052 >
>>
>>See PR#2521.  These may still be broken after the effects patch is
>>applied (I doubt it) but it's not worth fixing it first.
> 
>   Reading from sources this seems to be taken care of, except that there 
> is false comment in do_have_embassies_effect(). It claims that that 
> created contact is one-way, when make_contact() clearly makes two-way 
> contact.

But Marko Polo should make contact only one-way, I thought?  That's the 
way it was in the old code, and the way it should be (it can be a big 
disadvantage for other players to have contact with you).

jason