[Freeciv-Dev] Re: (PR#10074) auth database issues

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10074 >

Mike Kaufman wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=10074 >
> 
> here's a patch that adds a userdb_check_password() function
> it's needed because the database might (will) encrypt passwords and the
> server won't know about it. The one issue here is that the (possibly
> encrypted) password is stored in pconn->server.password which currently has
> a length of MAX_LEN_NAME (32 bytes) This is pretty small. For MD5, the
> digest is 32 bytes which is ok, but SHA1 is 40 bytes, bad. I suggest
> increasing the array to 512 bytes.

Does the function return a boolean or not?  It claims to return an 
integer but the caller treats it like a boolean.

jason