[Freeciv-Dev] (PR#9876) PATCH temperature parameters for Earth like generators 1,5

["Mateusz Stefek" <mstefek@xxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9876 >

> [mburda - Fri Sep 10 19:04:57 2004]:
> 
> > [mburda - Ven. Sep. 10 07:29:03 2004]: 
> >  
> > Update  
> >  
> Finally i simplify the TT_FRIZZED, now i am happy 
>   
> 
+/*
+ *  temperature_map[] stores the temperature of each tile
+ *  values on tmap can get one of these 4 values
+ *  there is 4 extra values as macros combining the 4 basics ones
+ */
+typedef enum {
+    TT_FRIZZED = 1, TT_COLD = 2, TT_TEMPERATE = 4, TT_TROPICAL = 8
+} temperature_type;
+#define TT_NFRIZZED (TT_COLD | TT_TEMPERATE | TT_TROPICAL)
+#define TT_ALL (TT_FRIZZED | TT_NFRIZZED)
+#define TT_NHOT (TT_FRIZZED | TT_COLD)
+#define TT_HOT (TT_TEMPERATE, TT_TROPICAL)
Don't use enums this way!!!
You cast enums into ints in create_tmap()

+#define map_pos_is_low(x, y) ((hmap((x), (y)) < hmap_low_level) || \
+                              is_ocean_near_tile((x), (y)))

This is unrelated and wrong IMO. Some shores can be very high.

--
mateusz