[Freeciv-Dev] (PR#10021) infinite loop in autosettlers?

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10021 >

On end-of-turn nothing happened for a long time.  So I SEGV'd the server 
and got this backtrace:

#0  0x08132113 in danger_iterate_map (pf_map=0x8525268) at 
path_finding.c:832
#1  0x08130cae in pf_next (pf_map=0x8525268) at path_finding.c:257
#2  0x0812314d in settler_map_iterate (parameter=0xbfb1f0f0, 
punit=0x8705f80,
     best=0xbfb1f180, pplayer=0x82a28cc, boat_cost=40) at aisettler.c:477
#3  0x0812353b in find_best_city_placement (punit=0x8705f80, 
best=0xbfb1f180,
     look_for_boat=true, use_virt_boat=false) at aisettler.c:601
#4  0x080aa874 in auto_settler_findwork (pplayer=0x82a28cc, punit=0x8705f80)
     at settlers.c:1133

...and skipping down a bit...

#9687 0x080aab2e in auto_settler_findwork (pplayer=0x82a28cc, 
punit=0x8705f80)
     at settlers.c:1192
#9688 0x080ab15c in auto_settlers_player (pplayer=0x82a28cc) at 
settlers.c:1314
#9689 0x080ab88e in auto_settlers_init () at settlers.c:1457
#9690 0x0804f5f7 in end_phase () at srv_main.c:563
#9691 0x0805103f in main_loop () at srv_main.c:1484
#9692 0x080518a4 in srv_loop () at srv_main.c:1805
#9693 0x080511c6 in srv_main () at srv_main.c:1561
#9694 0x0804a90a in main (argc=6, argv=0xbffff7e4) at civserver.c:170

This is with a modified version of the effects patch, but I doubt that 
matters.  Savegame is available but it doesn't seem to be reproducable. 
  I also have the original core file and executable.

(gdb) p *punit
$2 = {type = 0, id = 260, owner = 1, x = 52, y = 12, homecity = 129,
   moves_left = 3, hp = 20, veteran = 0, unhappiness = 0, upkeep = 0,
   upkeep_food = 1, upkeep_gold = 0, fuel = 0, bribe_cost = -1, ai = {
     control = true, ai_role = AIUNIT_NONE, ferryboat = 0, passenger = 0,
     bodyguard = 0, charge = 0, prev_struct = {x = 52, y = 12}, 
cur_struct = {
       x = 52, y = 12}, prev_pos = 0x8705fd4, cur_pos = 0x8705fdc, 
target = 0,
     hunted = 0}, activity = ACTIVITY_IDLE, goto_dest = {x = -1, y = -1},
   activity_count = 0, activity_target = S_NO_SPECIAL,
   focus_status = FOCUS_AVAIL, ord_map = 0, ord_city = 2, foul = false,
   debug = false, moved = false, paradropped = false, connecting = false,
   done_moving = false, transported_by = -1, occupy = 0, client = {color 
= 0},
   has_orders = false, orders = {length = 0, index = 0, repeat = false,
     vigilant = false, list = 0x0}}


jason