Complete.Org: Mailing Lists: Archives: freeciv-dev: September 2004:
[Freeciv-Dev] (PR#9918) create a pleced map and rename map_temperature h
Home

[Freeciv-Dev] (PR#9918) create a pleced map and rename map_temperature h

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: mburda@xxxxxxxxx
Subject: [Freeciv-Dev] (PR#9918) create a pleced map and rename map_temperature has map_lattitude
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Fri, 3 Sep 2004 11:50:40 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9918 >

You've got at least two different changes in here.

temperature => lattitude
T_NOT_PLACED => placed_map

also there's no need for a remove_placed_map.  Rename create_placed_map
as init_place_map and use realloc instead of malloc in it.

However having the placed map be global is dangerous.  You want it to
have multiple users: for hut placement, terrain placement, etc.  But
what if these users overlap?  The terrain placement code could end up
looking to see if a special has been placed yet on a tile.

jason



[Prev in Thread] Current Thread [Next in Thread]