[Freeciv-Dev] Re: (PR#9892) space part effects

["Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9892 >

On Tue, 31 Aug 2004, Jason Short wrote:

>
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=9892 >
>
> In Vasco's effects patch the Space_Part effect is replaced with
> SS_Component, SS_Structural, and SS_Module effects.  The only real
> advantage of this is that building_has_effect can be used directly
> (since that function returns a boolean rather than an integer).

Against what is this patch?  CVS?  Because you seem to forgot to update
building_has_effect so the first time it gets called you get an assert

>
> This patch makes that change, and removes most references to the space
> part enum values.  Unlike the effects patch, Space_Part is removed and
> all rulesets are updated.
>
> Note that if a space part has any other effects, bad things may happen.
>   Surely this should be documented, and possibly checked in the ruleset
> loading code.
>
> jason
>
>