Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2004:
[Freeciv-Dev] Re: (PR#9829) remove effect dio code
Home

[Freeciv-Dev] Re: (PR#9829) remove effect dio code

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: jdorje@xxxxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#9829) remove effect dio code
From: "Vasco Alexandre da Silva Costa" <vasc@xxxxxxxxxxxxxx>
Date: Fri, 27 Aug 2004 13:09:54 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9829 >

On Thu, 26 Aug 2004, Jason Short wrote:

>
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=9829 >
>
> This patch handles effects via arrays in the packets rather than using
> DIO callbacks.
>
> Vasco: IMO you should do the effects right in the building packet
> instead of in a separate "effects cache" packet (reminder: it's not a
> cache).  But if you insist I can rewrite this patch to use a new packet
> like you do.
>
> See PR#9828.

I fail to see the need of using arrays. Should you send a cities array as
well when you send the cities list? Everything will be serialized to send
through the line anyway. Makes no difference, and using the arrays is more
mucky in this case.

---
Vasco Alexandre da Silva Costa @ Instituto Superior Tecnico, Lisboa






[Prev in Thread] Current Thread [Next in Thread]
  • [Freeciv-Dev] Re: (PR#9829) remove effect dio code, Vasco Alexandre da Silva Costa <=