[Freeciv-Dev] Re: (PR#9788) RfP: G_MAGIC is evil

["Marko Lindqvist" <marko.lindqvist@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9788 >

Jason Short wrote:

> <URL: http://rt.freeciv.org/Ticket/Display.html?id=9788 >
> 
> government.h has a #define G_MAGIC 127.  This value should be changed to 
> MAX_NUM_GOVERNMENTS.  The value isn't magic at all, it's just a limit on 
> the number of governments.

  Max size of city too (why is this defined this way???):
#define G_CITY_SIZE_FREE          G_MAGIC

  IIRC revolution code also needed two special flag values, so G_MAGIC 
had to have different value from G_LAST to distinguish between the two. 
This has been since cleaned, I hope.


  - Caz