[Freeciv-Dev] Bug in agents queueing system

["Guillermo Lopez Alejos" <100030179@xxxxxxxxxxxxxxx>]

Hi,

I have find that the "turn_start_notify()" callback is not called for
the third defined agent... I'm starting thinking that it's only called
for the first defined agent.

See this:

The original agent initialization is (with puppeteer patch applied):

void agents_init(void)
{
  agents.entries_used = 0;
  call_list_init(&agents.calls);

  /* Add init calls of agents here */
  cma_init();
  cmafec_init();
  puppeteer_init_as_agent();
  simple_historian_init();
}

But if I put puppeteer_init_as_agent() and simple_historian_init() in
firs place:

void agents_init(void)
{
  agents.entries_used = 0;
  call_list_init(&agents.calls);

  /* Add init calls of agents here */
  puppeteer_init_as_agent();
  simple_historian_init();
  cma_init();
  cmafec_init();
}

Then "Puppeteer" agent is placed in the firs position of the
"agents.entries" array and the turn_start_notify() callback is performed
correctly (I supose that there is something in the CMA that stops
working if turn_start_notify() is not called for it).

Now I'm really busy with my final career project, but if I find the bug,
I'll submit a patch.

--
Guillermo López Alejos - N.I.A. 100030179
Universidad Carlos III de Madrid
Ingeniería Técnica en Informática de Gestión