[Freeciv-Dev] (PR#9502) nowhere for river to run

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9502 >

I got this error

2: Connection request from dorje from debian
2: c1 has client version 1.14.99-devel
2: dorje has connected from debian.
 > set topology 5
 > hard
Default AI skill level set to 'hard'.
 > set aifill 3
 > start
Starting game.
 >
2: Loading rulesets
 >
2: Ollam Fodla has been added as an AI-controlled player.
2: AI is controlling the Irish ruled by Ollam Fodla.
Player 'Ollam Fodla' now has AI skill level 'hard'.
2: Bao Dai has been added as an AI-controlled player.
2: AI is controlling the Vietnamese ruled by Bao Dai.
Player 'Bao Dai' now has AI skill level 'hard'.
civserver: mapgen.c:850: make_river: Assertion `best_val != -1' failed.


(gdb) p map.seed
$2 = 471220467
(gdb) p game.randseed
$3 = 1090815802


Is it coincidence that this only appears after the recent changes to 
this exact part of code?  It seems unlikely.  Is this another bug 
exposed, or has a new bug been introduced?

Naturally I can reproduce it with the following commands:

 > set seed 471220467
 > set randseed 1090815802
 > set topology 5
 > set aifill 3
 > create b
 > start

jason