[Freeciv-Dev] Re: (PR#9381) Bug: special case in city_buy_cost

["Jason Dorje Short" <jdorje@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9381 >

Vasco Alexandre da Silva Costa wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=9381 >
> 
>>[jdorje@xxxxxxxxxxx - Wed Jul 14 04:03:52 2004]:
>>
>>There is a special case for unstarted production in city_buy_cost(). 
>>This special case should be moved directly into the backend functions 
>>unit_buy_gold_cost and impr_buy_gold_cost.  The way it is now makes no 
>>sense.
> 
> 
> unit_buy_gold_cost and impr_buy_gold_cost do not accept a city pointer
> as an argument. You can add an additional argument, but there are uses
> of these functions which are not city related. For e.g. when using the
> unit upgrade option, unit_buy_gold_cost is checked.

But impr_buy_gold_cost does take the number of shields already 
allocated.  The special case is when this value is 0, which can be 
checked inside impr_buy_gold_cost/unit_buy_gold_cost...can't it?

jason