[Freeciv-Dev] (PR#2327) GUI problem with choosing government

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=2327 >

> [ChrisK@xxxxxxxx - Wed Nov 13 20:09:27 2002]:
> 
> Stable CVS Gtk 1.2 ~10 NOV 2002
> 
> This happened to a game-mate recently:
> 
> While chatting, the "choose government" popup appears, and grabs
> the keystrokes. A <space> or <return> chooses Despotism.
> 
> An expensive and frustrating mistake.
> 
> We could
> 
> - disable the keys for the popup at all
> - disable <space> and <return>, and add meta keys instead
> - someone wanted to make a new popup

Nothing involving the government happens until the end of the turn.  So
until the turn ends it should be possible to choose a new government
without returning to anarchy.

Game-design people: is there something wrong with this idea? 
Governments can potentially give some immediate-type effects, like a
make-veteran effect that affects combat.  In this case one might "cheat"
by switching to that government for part of the turn, then changing to a
different government.  However I'd argue that's a bug in the veteran
system: units shouldn't become veteran until the end of the turn.

jason