[Freeciv-Dev] Re: (PR#8683) remove specvec?
[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
<URL: http://rt.freeciv.org/Ticket/Display.html?id=8683 >
Jason Short wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8683 >
>
> Specvec (utility/specvec*) is unused. I didn't even know it existed
> until Raimar pointed it out to me today. It says that it creates
> variable-sized type-safe arrays ("what you end up doing when you don't
> use C++"). But C99 already has variable-sized typed arrays. So it
> should never be used.
>
> Can we remove it?
Here's the patch. It should be accompanied by a cvs rm of
utility/specvec_c.h and utility/specvec.h.
jason
Index: utility/Makefile.am
===================================================================
RCS file: /home/freeciv/CVS/freeciv/utility/Makefile.am,v
retrieving revision 1.2
diff -u -r1.2 Makefile.am
--- utility/Makefile.am 5 May 2004 20:39:16 -0000 1.2
+++ utility/Makefile.am 5 May 2004 21:41:27 -0000
@@ -38,8 +38,6 @@
shared.c \
shared.h \
speclist.h \
- specvec.h \
- specvec_c.h \
support.c \
support.h \
timing.c \
- [Freeciv-Dev] Re: (PR#8683) remove specvec?,
Jason Short <=
- [Freeciv-Dev] Re: (PR#8683) remove specvec?, Mike Kaufman, 2004/05/05
- [Freeciv-Dev] Re: (PR#8683) remove specvec?, Jason Short, 2004/05/05
- [Freeciv-Dev] Re: (PR#8683) remove specvec?, Vasco Alexandre da Silva Costa, 2004/05/05
- [Freeciv-Dev] Re: (PR#8683) remove specvec?, Vasco Alexandre da Silva Costa, 2004/05/05
- [Freeciv-Dev] Re: (PR#8683) remove specvec?, Per Inge Mathisen, 2004/05/06
- [Freeciv-Dev] Re: (PR#8683) remove specvec?, Jason Short, 2004/05/06
- [Freeciv-Dev] Re: (PR#8683) remove specvec?, Jason Short, 2004/05/06
- [Freeciv-Dev] Re: (PR#8683) remove specvec?, Mike Kaufman, 2004/05/06
- [Freeciv-Dev] (PR#8683) rewrite specvec so it doesn't use athing, Jason Short, 2004/05/12
- [Freeciv-Dev] (PR#8683) specvec iterator patch, Vasco Alexandre da Silva Costa, 2004/05/14
|
|