[Freeciv-Dev] (PR#8662) [PATCH] tests/Makefile.am fixes

["Marko Lindqvist" <marko.lindqvist@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8662 >


  1. Add check scripts to distribution
  2. Fix running of tests from separate builddir


  What I really don't like in this checks implementation (yes, I know I 
had the opportunity to look them vefore they were committed) is that 
they blatantly break against automake 'check' conventions. Starting from 
the fact that we define target 'check' ourselves instead of letting 
automake to do it for us (but then again, automake can't do it if we are 
not telling it anything about these tests...)
  This said, if things were written as they are simply because people 
were not aware of automake check support and not intentionally, I may 
look into fixing this. (I seem to be specializing into Makefile.ams here 
:) (Well, I mean that I'm ready to fix them anyway if it's not intention 
to keep them as they are)

  Oh dear, it's too late to rework this patch tonight so I send this as 
is even though I just realised it can't go in like this. In order to get 
test scripts distributed I added them to check_SCRIPTS. But those 
scripts are _not_ automake compliant check scripts. Since target 'check' 
is manually overridden, automake never tries to actually use them, but 
this is still no good. (For now) they should appear under noinst_SCRIPTS.


  - Caz