[Freeciv-Dev] Re: (PR#8526) city_draw_iterate macro

["Marcelo Burda" <NOSPAM_mburda@xxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8526 >

Le jeu 29/04/2004 à 07:30, Jason Short a écrit :
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8526 >
> 
> > [mburda - Wed Apr 28 07:45:10 2004]:

> Hey,
> 
Hi jason!

> This is practically identical to my city_draw_iterate patch in PR#8526.
>  Please take a look at my patch and see what you think.
> 
A was very busy last time then i get long time to make
city_map_iterate_known (today city_dlg_../city_draw_..) the own patch as
you ask me the 2004/2/19 from patch 7287. i see only now you make it
faster, nice!

> We should use is_valid_city_coords here instead of the hard-coded
> position check.
nice
>   And I think the macro should be confined to
> citydlg_common.c; nobody else should ever need it.
yes after last clean ups these macro can be confined there

> 
> About the name I'm not sure.
there is best if the "known" word is in the name to make logic more
clear. (there is more clear? my english is so bad)

The 2 and 3 usages of the macro can be probably merged in a single
iterate cycle a is in my patch. i find no problems.
> 
> jason
Marcelo