Complete.Org: Mailing Lists: Archives: freeciv-dev: April 2004:
[Freeciv-Dev] Re: (PR#8589) 6 test scripts
Home

[Freeciv-Dev] Re: (PR#8589) 6 test scripts

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: undisclosed-recipients: ;
Subject: [Freeciv-Dev] Re: (PR#8589) 6 test scripts
From: "Raimar Falke" <i-freeciv-lists@xxxxxxxxxxxxx>
Date: Sun, 25 Apr 2004 11:21:47 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8589 >

On Sun, Apr 25, 2004 at 11:10:34AM -0700, Jason Short wrote:
> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8589 >
> 
> Raimar Falke wrote:
> 
> > They all print some basic information what they do. They all assume
> > that your current dir is the top freeciv dir. They require
> > python2. Only start the .sh files.
> 
> So the idea is for these to go into the tests/ directory?  Then...

> We need a configure check for python2 that disables these tests if it's 
> not available.

IMHO overkill.

> They need to run from the tests directory.  We can easily pass 
> $(top_srcdir) as an argument to them.

Change the "." for the find command. Easy.

> We probably need a comparison text file.  It's hard to automate most 
> tests because the output needs to be scanned by humans.  But if we had, 
> for instance, a text file that had the "correct" output then the 
> script's output could be compared to that.  Unfortunately the correct 
> output may not be constant.  This problem doesn't seem solvable.

In each case

  tests/find_*.sh | grep -v '^#'

should be empty. No comparison text file needed.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 1 + 1 = 3, for large values of 1




[Prev in Thread] Current Thread [Next in Thread]