[Freeciv-Dev] Re: (PR#8548) configure messages for sound modules

["Per I. Mathisen" <per@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8548 >

On Mon, 19 Apr 2004, Jason Short wrote:
> > + if test "x$USE_SOUND_ALSA" = "xyes"; then
> > +dnl Add ALSA support to client
> > +AM_ALSA_SUPPORT(ALSA=yes, ALSA=no)
> > +if test "x$ALSA" != "xno"; then
> > +  SOUND_CFLAGS="$SOUND_CFLAGS $ALSA_CFLAGS"
> > +  SOUND_LIBS="$SOUND_LIBS $ALSA_LIB"
> > +  AC_DEFINE(ALSA, 1, [ALSA support])
> > +  AC_MSG_CHECKING(building ALSA support)
> > +  AC_MSG_RESULT(yes)
> >  fi
> > fi
>
> I think this usage of AC_MSG_CHECKING/AC_MSG_RESULT (used for all sound
> modules) isn't quite right.
>
> It should rather be:
>
> AC_MSG_CHECKING([for ALSA support])
> if test "$USE_SOUND_ALSA" = "yes"; then
>  AM_ALSA_SUPPORT(ALSA=yes, ALSA=no)
>  if test "$ALSA" != "no"; then
>    # Set up @SOUND_CFLAGS@, @SOUND_LIBS@, and ALSA #definition
>  fi
> else
>  ALSA=no
> fi
> AC_MSG_RESULT($ALSA)

The problem is that AM_ALSA_SUPPORT and similar calls print their own
stuff to the screen, which would then come between the checking message
and the result. It would be better to do the message as a whole after the
test. Like this:

> if test "$USE_SOUND_ALSA" = "yes"; then
>  AM_ALSA_SUPPORT(ALSA=yes, ALSA=no)
>  if test "$ALSA" != "no"; then
>    # Set up @SOUND_CFLAGS@, @SOUND_LIBS@, and ALSA #definition
>  fi
> else
>  ALSA=no
> fi
> AC_MSG_CHECKING([for ALSA support])
> AC_MSG_RESULT($ALSA)


  - Per