[Freeciv-Dev] (PR#8548) configure messages for sound modules

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8548 >

Per I. Mathisen wrote:

> + if test "x$USE_SOUND_ALSA" = "xyes"; then
> +  dnl Add ALSA support to client
> +  AM_ALSA_SUPPORT(ALSA=yes, ALSA=no)
> +  if test "x$ALSA" != "xno"; then
> +    SOUND_CFLAGS="$SOUND_CFLAGS $ALSA_CFLAGS"
> +    SOUND_LIBS="$SOUND_LIBS $ALSA_LIB"
> +    AC_DEFINE(ALSA, 1, [ALSA support])
> +    AC_MSG_CHECKING(building ALSA support)
> +    AC_MSG_RESULT(yes)
>    fi
>   fi

I think this usage of AC_MSG_CHECKING/AC_MSG_RESULT (used for all sound 
modules) isn't quite right.

It should rather be:

AC_MSG_CHECKING([for ALSA support])
if test "$USE_SOUND_ALSA" = "yes"; then
   AM_ALSA_SUPPORT(ALSA=yes, ALSA=no)
   if test "$ALSA" != "no"; then
     # Set up @SOUND_CFLAGS@, @SOUND_LIBS@, and ALSA #definition
   fi
else
   ALSA=no
fi
AC_MSG_RESULT($ALSA)

so that configure's output has better grammar "checking for ALSA 
support" versus "checking building ALSA support" and the message is 
given even if ALSA support isn't being built (so the user knows this).

jason