Complete.Org: Mailing Lists: Archives: freeciv-dev: April 2004:
[Freeciv-Dev] (PR#8518) Bugs in sha.c 		Home

[Freeciv-Dev] (PR#8518) Bugs in sha.c

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: jorgen.tegner@xxxxxxxxx
Subject: [Freeciv-Dev] (PR#8518) Bugs in sha.c
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Thu, 15 Apr 2004 11:50:52 -0700
Reply-to: rt@xxxxxxxxxxx 
<URL: http://rt.freeciv.org/Ticket/Display.html?id=8518 >

> [jorgen.tegner@xxxxxxxxx - Thu Apr 15 15:30:59 2004]:
> 
> Hi, 
> 
> there are a couple of bugs in sha.c where a null pointer (sometimes)
> gets dereferenced.
> 
> Adding simple checks like
> 
>   if(!punit) return;
> 
> after calls like
> 
>   struct unit *punit = find_unit_by_id(id);
> 
> took care of the immediate crashes I got on my machine.
> 
> I'm running cvs from 2004-04-14.

Can you make a patch?

jason
[Prev in Thread] Current Thread [Next in Thread]