[Freeciv-Dev] (PR#6406) gtk client crash on moving a caravel

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=6406 >

> [kauf - Thu Oct 09 03:52:22 2003]:
> 
> On Wed, Oct 08, 2003 at 05:54:40PM -0700, Jason Short wrote:
> > 
> > It looks like a gen-effects problem, but could be memory corruption
> > elsewhere.
> 
> I don't think it's the former. This is the old code which has been there 
> for ages with no problems. The core makes little sense to me.

It's a continents problem.  I can't reproduce a crash but I do get the
following error:

==1579== Conditional jump or move depends on uninitialised value(s)
==1579==    at 0x80B52FC: fill_ranges_improv_lists (improvement.c:345)
==1579==    by 0x80B5643: mark_improvement (improvement.c:518)
==1579==    by 0x80AF91F: city_add_improvement (city.c:2235)
==1579==    by 0x806E7C9: update_improvement_from_packet (packhand.c:248)
==1579== 
==1579== Conditional jump or move depends on uninitialised value(s)
==1579==    at 0x80B52FC: fill_ranges_improv_lists (improvement.c:345)
==1579==    by 0x80B535F: improvement_redundant (improvement.c:366)
==1579==    by 0x80B383D: update_all_effects (game.c:1082)
==1579==    by 0x806E810: try_update_effects (packhand.c:268)
==1579== 
==1579== Conditional jump or move depends on uninitialised value(s)
==1579==    at 0x80B52FC: fill_ranges_improv_lists (improvement.c:345)
==1579==    by 0x80B5643: mark_improvement (improvement.c:518)
==1579==    by 0x80B385B: update_all_effects (game.c:1087)
==1579==    by 0x806E810: try_update_effects (packhand.c:268)

Since pcity is set this means that map_get_continent(pcity->x, pcity->y)
is returning an unset value.

Perhaps the city info is being sent before the tile info?  Doesn't seem
likely...

Note that this is under S1_14.  All of this code has changed in the
meantime.  So there is limited use in fixing it.

jason