Complete.Org: Mailing Lists: Archives: freeciv-dev: April 2004:
[Freeciv-Dev] (PR#8500) packet_single_want_hack_req isn't freed
Home

[Freeciv-Dev] (PR#8500) packet_single_want_hack_req isn't freed

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: undisclosed-recipients: ;
Subject: [Freeciv-Dev] (PR#8500) packet_single_want_hack_req isn't freed
From: "jdorje@xxxxxxxxxxxx" <jdorje@xxxxxxxxxxxx>
Date: Mon, 12 Apr 2004 14:25:58 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8500 >

In the following code in srv_main.c:

   if (type == PACKET_SINGLE_WANT_HACK_REQ) {
     handle_single_want_hack_req(pconn,
                ((struct packet_single_want_hack_req *)packet)->challenge);
     return TRUE;
   }

packet should be freed before the return statement (this is done for all 
other packets).

However this isn't clean because the caller gives us packet directly. 
It should be the caller who frees it.

jason




[Prev in Thread] Current Thread [Next in Thread]
  • [Freeciv-Dev] (PR#8500) packet_single_want_hack_req isn't freed, jdorje@xxxxxxxxxxxx <=