[Freeciv-Dev] Re: (PR#8413) Server segfaults in stdinhand.c

["Per I. Mathisen" <per@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8413 >

On Sun, 28 Mar 2004, andrearo@xxxxxxxxxxxx wrote:
> I get a segfault in the server when executing a command from a client that
> is not bound to a player. Here's the output from gdb:
...
> To reproduce, connect a client to a server using authentication,
> and start a game. Then connect another client to the server, and issue
> _any_ command, and it results in a segfault.
>
> I've attached a suggestion for a fix, which uses the connection id
> instead of player id.

That is not a good fix. The vote table is the MAX_NUM_PLAYERS size big.
Here is a better one:

   if (caller
+      && caller->player
       && !check
       && caller->access_level == ALLOW_INFO
       && commands[cmd].level == ALLOW_CTRL) {

ie users not connected to a player should not be able to vote.

  - Per