[Freeciv-Dev] (PR#7475) switching tilesets crashes client

["Mike Kaufman" <kaufman@xxxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7475 >

using the GTK2 client:

start server.
> set top 7
connect client. (I have trident as the default)
start game
in client after game's started, switch tileset to isotrident. That works
fine. then switch back to trident. crash

also, after this crash, starting the client again and changing to
isotrident crashes the client, you don't to switch to iso and then back to
trident first. The two cores appear to be very similar.

-mike

#0  hash_fval_string (vkey=0x84ddff8, num_buckets=1543) at hash.c:188
188       for (; *key != '\0'; key++) {
(gdb) bt
#0  hash_fval_string (vkey=0x84ddff8, num_buckets=1543) at hash.c:188
#1  0x080cff2f in hash_lookup_data (h=0x607, key=0x84ddff8) at hash.c:576
#2  0x0808a29d in load_sprite (tag_name=0x30 <Address 0x30 out of bounds>)
    at tilespec.c:2581
#3  0x08087372 in tilespec_setup_tile_type (terrain=T_DESERT)
    at tilespec.c:1226
#4  0x08084189 in tilespec_reread (
    tileset_name=0x2 <Address 0x2 out of bounds>) at tilespec.c:358
#5  0x080bed2d in option_ok_command_callback (widget=0x830fb30, data=0x0)
    at gamedlgs.c:398
#6  0x40398d7a in g_cclosure_marshal_VOID__VOID ()
   from /usr/lib/libgobject-2.0.so.0
#7  0x40386d01 in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
#8  0x4039898c in signal_emit_unlocked_R () from
/usr/lib/libgobject-2.0.so.0
#9  0x403979a4 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
#10 0x40397c00 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
#11 0x40108225 in gtk_object_dispose () from /usr/lib/libgtk-x11-2.0.so.0
#12 0x401d0bb8 in gtk_widget_dispose () from /usr/lib/libgtk-x11-2.0.so.0
#13 0x401d5ad7 in gtk_window_dispose () from /usr/lib/libgtk-x11-2.0.so.0
#14 0x403888e8 in g_object_run_dispose () from /usr/lib/libgobject-2.0.so.0
#15 0x4010815c in gtk_object_destroy () from /usr/lib/libgtk-x11-2.0.so.0
#16 0x401c9395 in gtk_widget_destroy () from /usr/lib/libgtk-x11-2.0.so.0
#17 0x40399073 in g_cclosure_marshal_VOID () from
/usr/lib/libgobject-2.0.so.0
#18 0x40386d01 in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
#19 0x4039898c in signal_emit_unlocked_R () from
/usr/lib/libgobject-2.0.so.0
#20 0x403979a4 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
#21 0x40397c00 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
#22 0x400a5022 in gtk_dialog_response () from /usr/lib/libgtk-x11-2.0.so.0
#23 0x400a46db in action_widget_activated () from
/usr/lib/libgtk-x11-2.0.so.0
#24 0x40398d7a in g_cclosure_marshal_VOID__VOID ()
   from /usr/lib/libgobject-2.0.so.0
#25 0x40386d01 in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
#26 0x4039898c in signal_emit_unlocked_R () from
/usr/lib/libgobject-2.0.so.0
#27 0x403979a4 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
#28 0x40397c00 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
#29 0x40068265 in gtk_button_clicked () from /usr/lib/libgtk-x11-2.0.so.0
#30 0x40069154 in gtk_real_button_released () from
/usr/lib/libgtk-x11-2.0.so.0
#31 0x40398d7a in g_cclosure_marshal_VOID__VOID ()
   from /usr/lib/libgobject-2.0.so.0
#32 0x40387341 in g_type_class_meta_marshal ()
   from /usr/lib/libgobject-2.0.so.0
#33 0x40386d01 in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
#34 0x4039821c in signal_emit_unlocked_R () from
/usr/lib/libgobject-2.0.so.0
#35 0x403979a4 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
#36 0x40397c00 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
#37 0x400681b5 in gtk_button_released () from /usr/lib/libgtk-x11-2.0.so.0
#38 0x40068ffd in gtk_button_button_release ()
   from /usr/lib/libgtk-x11-2.0.so.0
#39 0x400ed443 in _gtk_marshal_BOOLEAN__BOXED ()
   from /usr/lib/libgtk-x11-2.0.so.0
#40 0x40387341 in g_type_class_meta_marshal ()
   from /usr/lib/libgobject-2.0.so.0
#41 0x40386d01 in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
#42 0x40398444 in signal_emit_unlocked_R () from
/usr/lib/libgobject-2.0.so.0
#43 0x40397708 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
#44 0x40397c00 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
#45 0x401cbcb1 in gtk_widget_event_internal ()
   from /usr/lib/libgtk-x11-2.0.so.0
#46 0x400ed254 in gtk_propagate_event () from /usr/lib/libgtk-x11-2.0.so.0
#47 0x400ec0d6 in gtk_main_do_event () from /usr/lib/libgtk-x11-2.0.so.0
#48 0x402a126f in gdk_event_dispatch () from /usr/lib/libgdk-x11-2.0.so.0
#49 0x403de7ff in g_main_dispatch () from /usr/lib/libglib-2.0.so.0
#50 0x403dcd59 in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0
#51 0x403decad in g_main_context_iterate () from /usr/lib/libglib-2.0.so.0
#52 0x403dd2fc in g_main_loop_run () from /usr/lib/libglib-2.0.so.0
#53 0x400eb987 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0
#54 0x080a6a26 in ui_main (argc=1, argv=0xbffff974) at gui_main.c:1206
#55 0x0806b6a7 in main (argc=1, argv=0xbffff974) at civclient.c:244
#56 0x4050b767 in __libc_start_main () from /lib/libc.so.6