[Freeciv-Dev] (PR#7003) Re: core file on civserver, http://civserver.freeciv.org/games/231727

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7003 >

> [i-freeciv-lists@xxxxxxxxxxxxx - Sun Nov 30 21:20:39 2003]:
> 
> On Sun, Nov 30, 2003 at 06:29:09AM -0800,
> freeciv@xxxxxxxxxxxxxxxxxxxxx wrote:
> > #0  0x400750a1 in kill () from /lib/libc.so.6
> > #1  0x40074e99 in raise () from /lib/libc.so.6
> > #2  0x40076364 in abort () from /lib/libc.so.6
> > #3  0x4006f15d in __assert_fail () from /lib/libc.so.6
> > #4  0x0804a97e in real_die () at shared.c:663
> > #5  0x08062d3e in real_sanity_check_city (pcity=0x8383b18,
> >     file=0x80d4c48 "cityturn.c", line=174) at cityturn.c:157
> > #6  0x08062d81 in auto_arrange_workers (pcity=0x8383b18) at
> cityturn.c:174
> > #7  0x0806273e in update_city_tile_status (pcity=0x8383b18,
> city_x=2, city_y=3)
> >     at citytools.c:2046
> > #8  0x08062551 in server_set_tile_city (pcity=0x8285bf8, city_x=2,
> city_y=1,
> >     type=C_TILE_UNAVAILABLE) at citytools.c:1974
> > #9  0x08062780 in update_city_tile_status (pcity=0x8285bf8,
> city_x=2, city_y=1)
> >     at citytools.c:2061
> > #10 0x08062551 in server_set_tile_city (pcity=0x8383b18, city_x=2,
> city_y=3,
> >     type=C_TILE_WORKER) at citytools.c:1974
> > #11 0x08062652 in server_set_worker_city (pcity=0x8383b18, city_x=2,
> city_y=3)
> >     at citytools.c:2001
> > #12 0x08062fe4 in auto_arrange_workers (pcity=0x8383b18) at
> cityturn.c:241
> > #13 0x0806273e in update_city_tile_status (pcity=0x8383b18,
> city_x=3, city_y=2)
> >     at citytools.c:2046
> > #14 0x080626a9 in update_city_tile_status_map (pcity=0x8383b18,
> map_x=12,
> >     map_y=19) at citytools.c:2018
> > #15 0x080747f4 in tile_update_owner (x=12, y=19) at maphand.c:1579
> > #16 0x080749a9 in map_update_borders_recalculate_position (x=11,
> y=19)
> >     at maphand.c:1597
> > #17 0x08074a20 in map_update_borders_city_change (pcity=0x8383b18)
> >     at maphand.c:1629
> > #18 0x08060502 in transfer_city (ptaker=0x81fcca4, pcity=0x8383b18,
> >     kill_outside=0, transfer_unit_verbose=true, resolve_stack=true,
> raze=true)
> >     at citytools.c:863
> > #19 0x0806147b in handle_unit_enter_city (punit=0x8291480,
> pcity=0x8383b18)
> >     at citytools.c:1303
> > #20 0x0805c765 in handle_unit_move_consequences (punit=0x8291480,
> src_x=10,
> >     src_y=20, dest_x=11, dest_y=19) at unittools.c:2758
> > #21 0x0805d048 in move_unit (punit=0x8291480, dest_x=11, dest_y=19,
> >     transport_units=true, take_from_land=true, move_cost=3) at
> unittools.c:3060
> > #22 0x0805583a in handle_unit_move_request (punit=0x8291480, x=11,
> y=19,
> >     igzoc=false, move_diplomat_city=false) at unithand.c:1120
> > #23 0x08054b80 in handle_move_unit (pplayer=0x81fcca4,
> pmove=0xbffff170)
> >     at unithand.c:661
> > #24 0x080b8d72 in ai_unit_attack (punit=0x8291480, x=11, y=19) at
> aitools.c:346
> > #25 0x080b871d in ai_unit_execute_path (punit=0x8291480,
> path=0x8376860)
> >     at aitools.c:118
> > #26 0x080bae64 in ai_military_rampage (punit=0x8291480,
> thresh_adj=1,
> >     thresh_move=1) at aiunit.c:1099
> > #27 0x080bd4d7 in ai_military_attack (pplayer=0x81fcca4,
> punit=0x8291480)
> >     at aiunit.c:2237
> > #28 0x080be15e in ai_manage_military (pplayer=0x81fcca4,
> punit=0x8291480)
> >     at aiunit.c:2656
> > #29 0x080be646 in ai_manage_units (pplayer=0x81fcca4) at
> aiunit.c:2798
> > #30 0x0804cb0b in ai_start_turn () at srv_main.c:436
> > #31 0x0804e08d in main_loop () at srv_main.c:1447
> > #32 0x0804e29e in srv_main () at srv_main.c:1590
> > #33 0x08049ab0 in main (argc=9, argv=0xbffff384) at civserver.c:154
> > #34 0x400641c4 in __libc_start_main () from /lib/libc.so.6
> 
> Server output:
> 
> 0: Detected fatal error in cityturn.c line 157:
> 0: Huanuco is illegal (size1 w1 e2 t0 s0) in cityturn.c line 174
> 
> Interresting stack trace. However I can't reproduce this from the last
> savegame.

Is this with the (at the time) most recent CVS version?

Until recently, there was a significant bug because auto_arrange_workers
wasn't re-entrant and it could be recursively called under some
situations.  I added a hack so that it should be safely re-entrant.

None of the line numbers above match up with current code, so I don't
know what's going on.  But I do suspect the whole thing needs to be
redesigned.

jason