[Freeciv-Dev] Re: (PR#7311) rewrite create_start_positions

["Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7311 >

On Sat, 24 Jan 2004, Jason Short wrote:

> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=7311 >
> 
> This patch rewrites create_start_positions to use rand_map_pos_filtered.

Comments:

1. "Give a random square anywhere on the map..."  A square?  You surely 
mean a position or a tile.

2. You might as well incorporate is_illegal_start_pos into your filter 
function.

3. Remove MAXTRIES define, since you remove the only mention of it.

> The main advantage is that it fails more consistently: we don't have to

"Fails more consistently" is a great advertisement!  To my ear it sounds 
like "fails every time" ;)

I think the patch is good and ready to go in once you answer the comments 
above.

G.