[Freeciv-Dev] Re: (PR#7227) civ1 ruleset warnings

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7227 >

Per I. Mathisen wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=7227 >
> 
> Try to start any civ1 ruleset game:
> 
> 2: Loading rulesets
> 1: Civil war nation italian for nation Roman not defined.
> 1: Civil war nation spanish for nation Roman not defined.
> 1: Civil war nation israeli for nation Babylonian not defined.
> 1: Civil war nation persian for nation Babylonian not defined.
> 1: Civil war nation arab for nation Babylonian not defined.
> 1: Civil war nation italian for nation German not defined.
> 1: Civil war nation israeli for nation Egyptian not defined.
> etc etc
> 
> Not known whether civil war works fine anyway.

This patch turns the message into VERBOSE.  I'm not sure if this is 
really the correct thing to do (see the comment in the patch).

Personally, I think the civ1 ruleset should include all nations.

jason

Index: server/ruleset.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/server/ruleset.c,v
retrieving revision 1.160
diff -u -r1.160 ruleset.c
--- server/ruleset.c    2004/01/11 17:45:05     1.160
+++ server/ruleset.c    2004/01/16 02:16:59
@@ -2326,7 +2326,12 @@
 
       if (pl->civilwar_nations[j] == -1) {
        j--;
-       freelog(LOG_ERROR, "Civil war nation %s for nation %s not defined.",
+       /* For nation authors this would probably be considered an error.
+        * But it can happen normally.  The civ1 compatability ruleset only
+        * uses the nations that were in civ1, so not all of the links will
+        * exist. */
+       freelog(LOG_VERBOSE,
+               "Civil war nation %s for nation %s not defined.",
                civilwar_nations[k], pl->name);
       }
     }