Complete.Org: Mailing Lists: Archives: freeciv-dev: December 2003:
[Freeciv-Dev] is_server kludges
Home

[Freeciv-Dev] is_server kludges

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: "Freeciv-Dev" <freeciv-dev@xxxxxxxxxxx>
Subject: [Freeciv-Dev] is_server kludges
From: "Brandon J. Van Every" <vanevery@xxxxxxxxxxxxxxxxxxx>
Date: Tue, 23 Dec 2003 09:43:38 -0800

I'm working from Freeciv 1.14.1 stable sources.  I'm trying to compile
the code in freeciv\common as a DLL.  I find there is some kludge:

is_server - a global variable in both \client and \server
dealloc_id - has different definitions in \common, \client, and \server
send_unit_info - has different definitions in \client and \server

I know you guys weren't trying to have \common be a DLL, but it's rather
unclean to have a library implement modality using globals in .exe's
that aren't part of the library.  Do you guys have an opinion on
cleaning this up?  If so, I could submit a patch based on your input.
If not, I'll get on with doing it properly.


Cheers,                     www.indiegamedesign.com
Brandon Van Every           Seattle, WA

Taking risk where others will not.



[Prev in Thread] Current Thread [Next in Thread]
  • [Freeciv-Dev] is_server kludges, Brandon J. Van Every <=