[Freeciv-Dev] (PR#7131) client orders to replace client goto

["Jason Short" <jdorje@xxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7131 >

Currently client-side goto and patrol are implemented by sending the 
server a list of map positions.  There is a special-case that the same 
position twice causes the unit to wait (needed for tririemes and danger 
positions).  Patrol and goto are handled by the same code, although they 
are treated as different activities.

Arnstein's "mission orders" patch extends this by allowing an "order" to 
be tacked on to the end of the goto.  This is a useful feature, but the 
implementation isn't general enough to have long-term use.

In an IRC discussion I proposed that the client send the server an 
arbitrary list of "orders".  Each order is like

   order = move <dir> | do <action> | wait
   action = activity, diplomat action, caravan action, etc.

The orders may be repeated if a flag is set (e.g., patrols).

This allows client-side goto and patrols, as well as mission orders to 
be handled by one fairly simple (and dumb) piece of code in the server. 
  It also potentially allows the "connect" feature to be done the same 
way (allowing a much better user interface).  In theory auto-settlers, 
auto-explore, etc. could be done the same way.

The initial implementation will replace the goto packet with an orders 
packet, with corresponding changes in client and server.  Further 
changes will introduce new actions.

jason