[Freeciv-Dev] Re: (PR#7040) Small cleanup packhand.c

["Raimar Falke" <i-freeciv-lists@xxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7040 >

On Fri, Dec 05, 2003 at 05:00:46AM -0800, Arnstein Lindgard wrote:
>      agents_unit_changed(punit);

> -  if (punit && punit == get_unit_in_focus()) {
> +  /* Will agents_unit_changed() above be allowed to destroy the unit? */
> +  assert(punit != NULL);

A call to agents_*_changed inside a
PACKET_PROCESSING_STARTED/PACKET_PROCESSING_FINISHED or
PACKET_FREEZE_HINT/PACKET_THAW_HINT pair will always only enqueue a
call. No modifying function is called. Every packet which the client
receives is/should be inside such a pair.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  "Heuer's Law: Any feature is a bug unless it can be turned off."