[Freeciv-Dev] Re: (PR#6923) Free connection buffers at client exit

["Jason Short" <jshort@xxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=6923 >

>
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=6923 >
>
>
> The buffers for the server connection are not freed at client
> exit. The attached patch fixes this but reveals other problems:
> disconnect_from_server calls close_socket_nomessage
>  close_socket_nomessage calls set_client_state(CLIENT_PRE_GAME_STATE)
>  set_client_state(CLIENT_PRE_GAME_STATE) calls set_unit_focus(NULL)
>  set_unit_focus(NULL) calls refresh_tile_mapcanvas
>
> refresh_tile_mapcanvas needs the tileset sprites. These sprites are
> however already freed previously in ui_main.
>
> Solutions welcome.

Some can_client_*** check should be done at some point in there, probably
within set_unit_focus.

jason