Complete.Org: Mailing Lists: Archives: freeciv-dev: November 2003:
[Freeciv-Dev] (PR#6870) Replace int with enum event_type 		Home

[Freeciv-Dev] (PR#6870) Replace int with enum event_type

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: i-freeciv-lists@xxxxxxxxxxxxx
Subject: [Freeciv-Dev] (PR#6870) Replace int with enum event_type
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Tue, 18 Nov 2003 20:25:15 -0800
Reply-to: rt@xxxxxxxxxxx 
<URL: http://rt.freeciv.org/Ticket/Display.html?id=6870 >

> [i-freeciv-lists@xxxxxxxxxxxxx - Sat Nov 15 15:22:04 2003]:

> The only semantic change is this:
> 
> -  if (event != 0)
> +  if (event != E_NOEVENT)
> 
> I think the old version is wrong here.

It seems you are correct.

However I'm pretty sure from a translator's point of view, both methods
are wrong.  I think the use of the 'source' string will potentially give
bad grammar under some languages if it is ever allowed to have more than
one value.  Any translators care to comment?

jason
[Prev in Thread] Current Thread [Next in Thread]