[Freeciv-Dev] Re: (PR#6718) Cannot client goto caravan into other player's city

["Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxx>]

On Wed, 5 Nov 2003, Raimar Falke wrote:

> On Wed, Nov 05, 2003 at 12:17:39PM -0800, Gregory Berkolaiko wrote:
> > 
> > On Wed, 5 Nov 2003, Raimar Falke wrote:
> > 
> > > On Sat, Nov 01, 2003 at 03:13:41AM -0800, Per I. Mathisen wrote:
> > > > 
> > > > Small bug: You cannot use client goto to send a caravan into a city 
> > > > owned
> > > > by another player. Savegame attached.
> > > > 
> > > > (Since the savegame is made in civworld, you must give the caravan a 
> > > > home
> > > > city before trying to use it.)
> > > 
> > > And the easy fix.
> > 
> > This way goto can suggest paths that attack units
> 
> Good catch. New untested version attached. 

There are problems still I think.  It assumes you cannot see units inside 
other player's cities.

If you can see inside a city (shared vision? bugged client?) and it has
some other player's units, the caravan won't go there.  Move the check for
the city up and check for the units down.

G.