[Freeciv-Dev] (PR#6678) Server dumps core and client runs crazy

["Christian Knoke" <chrisk@xxxxxxxxx>]

CVS 29 OCT 2003 HEAD GTK 1.2

A savegame with

version=11401
server_state=2
metastring="unstable pre-1.14.1: beware"

makes the server crash, gives bad client behavior, and eventually crashes
the client, too. If this is of any interest, I can post a savegame. Details
below.

Christian


The savegame mediummap+1540m.sav.gz makes the server dump core
on game start. The client output shows:

chris@max:~> LANG= civclient -t trident -P none
2: lost connection to server
2: error in select() return=-1 errno=9 (Bad file descriptor)
2: lost connection to server
2: error in select() return=-1 errno=9 (Bad file descriptor)
2: lost connection to server
2: error in select() return=-1 errno=9 (Bad file descriptor)
2: lost connection to server
2: error in select() return=-1 errno=9 (Bad file descriptor)
2: lost connection to server
1: CMA: Århus has changed multiple times due to an error in Freeciv. Please
send a savegame that can reproduce this bug to <bugs@xxxxxxxxxxxxxxxxxxx>.
Thank you.
2: error in select() return=-1 errno=9 (Bad file descriptor)
2: lost connection to server
2: error in select() return=-1 errno=9 (Bad file descriptor)
2: lost connection to server
2: error in select() return=-1 errno=9 (Bad file descriptor)
2: lost connection to server
2: error in select() return=-1 errno=9 (Bad file descriptor)
2: lost connection to server
2: error in select() return=-1 errno=9 (Bad file descriptor)
2: lost connection to server
1: CMA: Mönchengladbach has changed multiple times due to an error in
Freeciv. Please send a savegame that can reproduce this bug to
<bugs@xxxxxxxxxxxxxxxxxxx>. Thank you.
2: error in select() return=-1 errno=9 (Bad file descriptor)

repeatedly. This is accompanied by an repeatedly opened/closed connect
window, while the F10 window is updated.

chris@max:~/freeciv/games> gdb civserver -core core
...
251         if (ai->government_want[gov->index] > best_val 
(gdb) bt
#0  0x080ccc7c in ai_best_government (pplayer=0x81ff4e8) at aihand.c:251
#1  0x080cc3bf in ai_data_turn_init (pplayer=0x81ff4e8) at aidata.c:305
#2  0x0804e010 in begin_turn () at srv_main.c:468
#3  0x0804f86c in main_loop () at srv_main.c:1445
#4  0x08050050 in srv_loop () at srv_main.c:1812
#5  0x0804fac0 in srv_main () at srv_main.c:1599
#6  0x0804a297 in main (argc=3, argv=0xbffff424) at civserver.c:154
#7  0x400a07ee in __libc_start_main () from /lib/libc.so.6

When I repeat this, without restarting the client, the client also dumps
core:

civclient: map.c:253: map_allocate: Assertion `map.tiles == ((void *)0)'
failed.
Abgebrochen (core dumped)

(gdb) bt
#0  0x4035f861 in kill () from /lib/libc.so.6
#1  0x4035f665 in raise () from /lib/libc.so.6
#2  0x40360c81 in abort () from /lib/libc.so.6
#3  0x40359a52 in Letext () from /lib/libc.so.6
#4  0x080c372b in map_allocate () at map.c:253
#5  0x080767fd in handle_map_info (pinfo=0x8312910) at packhand.c:1235
#6  0x08065e69 in handle_packet_input (packet=0x8312910, type=16) at
civclient.c:309
#7  0x080692f3 in input_from_server (fd=6) at clinet.c:330
#8  0x0809c142 in get_net_input (data=0x0, fid=6, condition=GDK_INPUT_READ)
    at gui_main.c:1141
#9  0x40194934 in gdk_io_invoke () from /usr/lib/libgdk-1.2.so.0
#10 0x401c63b0 in g_io_unix_dispatch () from /usr/lib/libglib-1.2.so.0
#11 0x401c7c46 in g_main_dispatch () from /usr/lib/libglib-1.2.so.0
#12 0x401c8273 in g_main_iterate () from /usr/lib/libglib-1.2.so.0
#13 0x401c843c in g_main_run () from /usr/lib/libglib-1.2.so.0
#14 0x400e076c in gtk_main () from /usr/lib/libgtk-1.2.so.0
#15 0x0809bc8d in ui_main (argc=1, argv=0xbffff444) at gui_main.c:963
#16 0x08065d6f in main (argc=5, argv=0xbffff444) at civclient.c:244
#17 0x4034e7ee in __libc_start_main () from /lib/libc.so.6

-- 
Christian Knoke            * * *            http://cknoke.de
* * * * * * * * *  Ceterum censeo Microsoft esse dividendum.