[Freeciv-Dev] Re: (PR#6411) genlist cleanup

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

Raimar Falke wrote:
> On Fri, Oct 10, 2003 at 01:16:05PM -0700, Jason Short wrote:
> 
>>[per - Thu Oct  9 21:25:05 2003]:
>>
>>
>>>Here is a new version. Less lines of changes, since I reused the old
>>>iterator macros like Jason wanted. Also fixed a serious bug.
>>
>>OK...
>>
>>But gui-gtk at least doesn't compile with this; citydlg.c still uses
>>genlist_iterator.
> 
> 
> Per can you please update the patch so that it covers all the code.
> 
> Does anybody have a list of code places where we use the genlist
> directly i.e. without the iterate? Can these places be converted?

Quite a few.  I assume so, but I don't really know how.

jason

./client/gui-gtk/citydlg.c:  genlist_iterator_init(&myiter, &(plist->list),
./client/gui-gtk/citydlg.c:  genlist_iterator_init(&myiter, &(plist->list),
./client/gui-gtk/citydlg.c:  genlist_iterator_init(&myiter, &(plist->list),
./client/gui-gtk/citydlg.c:  genlist_iterator_init(&myiter, &(plist->list),
./client/gui-mui/citydlg.c:  genlist_iterator_init(&myiter, &dialog_list, 0);
./client/gui-mui/citydlg.c:  genlist_iterator_init(&myiter, &dialog_list, 0);
./client/gui-mui/citydlg.c:  genlist_iterator_init(&myiter, &(plist->list), 0);
./client/gui-mui/citydlg.c:  genlist_iterator_init(&myiter, &(plist->list), 0);
./client/gui-mui/citydlg.c:  genlist_iterator_init(&myiter, &(plist->list), 0);
./client/gui-mui/citydlg.c:  genlist_iterator_init(&myiter, &(plist->list), 0);
./client/gui-sdl/citydlg.c:  genlist_iterator_init(&myiter, &(pList->list), 0);
./client/gui-win32/citydlg.c:  genlist_iterator_init(&myiter, &(plist->list), 
0);
./client/gui-win32/citydlg.c:  genlist_iterator_init(&myiter, &(plist->list), 
0); 
./client/gui-win32/citydlg.c:  genlist_iterator_init(&myiter, &dialog_list, 0);
./client/gui-win32/citydlg.c:  genlist_iterator_init(&myiter, &dialog_list, 0);
./client/gui-win32/dialogs.c:  genlist_iterator_init(&myiter,&nation_list,0);
./client/gui-win32/gui_stuff.c:  genlist_iterator_init(&myiter,&td->tabslist,0);
./client/gui-win32/gui_stuff.c:  genlist_iterator_init(&myiter,&td->tabslist,0);
./client/gui-win32/gui_stuff.c:  
genlist_iterator_init(&myiter,&box->item_list,0);
./client/gui-win32/gui_stuff.c:      
genlist_iterator_init(&myiter,&box->item_list,0);
./client/gui-win32/gui_stuff.c:      
genlist_iterator_init(&myiter,&box->item_list,0);
./client/gui-win32/gui_stuff.c:    
genlist_iterator_init(&myiter,&box->item_list,0);
./client/gui-win32/gui_stuff.c:  
genlist_iterator_init(&myiter,&box->item_list,0);
./client/gui-xaw/citydlg.c:  genlist_iterator_init(&myiter,
./client/gui-xaw/citydlg.c:  genlist_iterator_init(&myiter, 
./common/genlist.c:void genlist_iterator_init(struct genlist_iterator *iter,
./common/genlist.c:  genlist_iterator_init(&myiter, pgenlist, 0);
./common/genlist.c:  genlist_iterator_init(&myiter, pgenlist, 0);
./common/genlist.h:void genlist_iterator_init(struct genlist_iterator *iter,
./common/genlist.h:  genlist_iterator_init(&myiter, &(typed_list).list, 0);   \
./common/genlist.h:  genlist_iterator_init(&myiter, &(typed_list).list, -1);  \
./common/registry.c:    for(genlist_iterator_init(&ent_iter, 
&psection->entries.list, 0);
./doc/HACKING:  genlist_iterator_init(&myiter, &punit_list->list, 0);