[Freeciv-Dev] Re: (PR#6379) implement get_mapview_corners for iso-maps

["rwetmore@xxxxxxxxxxxx" <rwetmore@xxxxxxxxxxxx>]

Jason Short wrote:
>    map_to_overview_pos(&x[0], &y[0],
>                     mapview_canvas.map_x0, mapview_canvas.map_y0);
>  
> -  if (is_isometric) {
> +  /* Note: these calculations manipulate native coordinates directly. */
                                             ^^^^^^
 > +  if (is_isometric && !topo_has_flag(TF_ISO)) {

No they don't. These are overview coordinates, no?

Native coordinates describe a certian 2-D storage layout.

Overview coordinates describe an Overview map in coordinates particular to
the overview object.

While the two sets of coordinate may appear to have a lot of similarity, one
should not confuse them and certainly not mis-document the situation.


As a general comment, the GUI gen-topology patch is really not doing a very
good job of encapsulating the topology code. It is really just a lot of
rearrangement of the previous isometric hacks into the baseline standard
code at the moment. One really shouldn't see code like is_isometric and
topo_has_flag() in general code flow, but rather only buried in gen_topo code
routines, right?

Cheers,
RossW
=====