[Freeciv-Dev] Re: (PR#6260) Assert in server on city size

["Per I. Mathisen" <per@xxxxxxxxxxx>]

On Tue, 30 Sep 2003, Jason Short wrote:
> > auto_arrange_workers should NOT, NOT, NOT be calling the helper
> > functions to change the city workers. Each of these helper functions
> > calls various other helper functions, way on down the line, which can
> > (but should not) result in a recursive call back to
> > auto_arrange_workers.

I am not sure this is the problem. I tried commenting out the call to
auto_arrange_workers(), and that didn't help. I also got this assert with
your patch with another autogame:

#2  0x42020f95 in __assert_fail () from /lib/tls/libc.so.6
#3  0x08066b8a in auto_arrange_workers (pcity=0x83700e0) at cityturn.c:244
#4  0x0805f850 in handle_unit_move_consequences (punit=0xbfffe354,
src_x=5,
    src_y=36, dest_x=5, dest_y=37) at unittools.c:2821
#5  0x0805fcfc in move_unit (punit=0x85fa5e0, dest_x=5, dest_y=37,
    transport_units=true, take_from_land=true, move_cost=3) at
unittools.c:3060
#6  0x08057ed6 in handle_unit_move_request (punit=0x85fa5e0, x=5, y=37,
    igzoc=false, move_diplomat_city=false) at unithand.c:1120
#7  0x0805709e in handle_move_unit (pplayer=0x8207270, pmove=0xbfffe500)
    at unithand.c:661
#8  0x080c570b in ai_unit_move (punit=0x85fa5e0, x=5, y=37) at
aitools.c:414
#9  0x080c4b8a in ai_unit_execute_path (punit=0x85fa5e0, path=0x860ec38)
    at aitools.c:120

Does not look like recursion is involved directly.

  - Per