[Freeciv-Dev] (PR#6266) New bug introduced by 'Don't send transported units to players without shared vision' patch

["mateusz stefek" <matusik_s@xxxxx>]

> civserver: map.c:1317: same_pos: Assertion `is_normal_map_pos((x1), 
> (y1))' failed.

Program received signal SIGABRT, Aborted.
0x400ea481 in kill () from /lib/i686/libc.so.6
(gdb) backtrace
#0  0x400ea481 in kill () from /lib/i686/libc.so.6
#1  0x400ea215 in raise () from /lib/i686/libc.so.6
#2  0x400eb76b in abort () from /lib/i686/libc.so.6
#3  0x400e3745 in __assert_fail () from /lib/i686/libc.so.6
#4  0x080bb637 in same_pos (x1=68, y1=68, x2=68, y2=31) at map.c:1317
#5  0x080619c5 in send_unit_info_to_onlookers (dest=0x827a9d8,
    punit=0x8530850, x=68, y=68, remove_unseen=true) at unittools. 
c:1915
#6  0x080646d4 in move_unit (punit=0x8530850, dest_x=68, dest_y=31,
    transport_units=false, take_from_land=true, move_cost=3)
    at unittools.c:2992
...

This is probably very stupid bug at unittools:2992:

    /*
     * Send updated information to anyone watching that unit is on  
transport.
     * All players without shared vison with owner player get
     * REMOVE_UNIT package.
     */
    send_unit_info_to_onlookers(NULL, punit, punit->x, punit->x, TRUE);
                                             ^^^^^^^^^^^^^^^^^^
--
mateusz