Complete.Org: Mailing Lists: Archives: freeciv-dev: September 2003:
[Freeciv-Dev] Re: (PR#5378) Automatic style enforcement
Home

[Freeciv-Dev] Re: (PR#5378) Automatic style enforcement

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: dspeyer@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#5378) Automatic style enforcement
From: "Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxx>
Date: Fri, 19 Sep 2003 10:02:13 -0700
Reply-to: rt@xxxxxxxxxxxxxx

On Fri, 19 Sep 2003, John Wheeler wrote:

> [glip - Fri Sep 19 12:44:18 2003]:
> 
> > On Wed, 17 Sep 2003, Daniel L Speyer wrote:
> > 
> > > OK, the "if("s are fixed.  That's all I found for remaining style 
> > > errors.  This whole style thing is getting really annoying.  Has 
> > > anyone written some tools to help with it?
> > 
> > I don't know any such tools unfortunately.  I think Raimar had
> > something.
> 
> Would 'indent' work? (http://www.gnu.org/directory/indent.html)

Not on a separate patch.

> If so, after getting the settings as desired, it should be possible to
> apply it to all the files at once if you really want to enforce a
> certain style.  (Of course, that means that files would be updated that
> have no change in code.)  In any case, I'd suggest putting such settings
> as a cut-and-paste command line in "How to Contribute" so that people
> can apply indent before submitting patches, and possibly automatically
> applying indent before committing new files.

Incidentally, this info is there.  It says 
        (when in doubt, use "indent -kr -i2")
in
        http://www.freeciv.org/contribute.html#Style

Not all of the style preferences are enforced but these settings, but 
those which aren't are minor.

G.




[Prev in Thread] Current Thread [Next in Thread]
  • [Freeciv-Dev] Re: (PR#5378) Automatic style enforcement, Gregory Berkolaiko <=