[Freeciv-Dev] (PR#4757) server_crash: pending_seen is off

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

[glip - Wed Sep 17 15:11:05 2003]:

> Hurray, we have a savegame which reliably reproduces the crash.  Courtesy 
> of John Wheeler.  I uploaded it directly to RT (via Comment facility).

Theodoric has some fanatics at (75, 26), as well as 5 other units off a
ways.  The pending_seen error is at 76,25.  There is a city at this
position belonging to Theodoric.  The error occurs in move_unit when the
Fanatics move out of the city.

Oddly, Theodoric seems to have just been summoned this turn.  Or
something.  When the savegame is loaded Genseric exists but not
Theodoric.  summon_barbarians() is called, but I didn't step through it
very far.  At this point Genseric has is_alive==FALSE, but still has one
unit remaining.  Yes, it's the same partisans as above (ID 293).

In fact Genseric is already dead when the game is loaded, and his
partisans are there the whole time.  So perhaps this is not enough to
trace the whole bug...

This may be the same as PR#4596 ("partisan invisible").

There is also (and has been) an attached rt4757.sav.gz from Miyo
(pajuma@xxxxxx).  This savegame also reproduces the bug, but with
slightly different circumstances.  The error occurrs in
server_remove_unit so at the time of the crash the data has already been
overwritten.  I didn't look any further.

jason