[Freeciv-Dev] Re: (PR#1178) Active Units Dialog

["jjc@xxxxxxxxxxxxxxxxxx" <jjc@xxxxxxxxxxxxxxxxxx>]

On Wed, Sep 10, 2003 at 02:32:08PM -0700, Vasco Alexandre da Silva Costa wrote:
> 
> [vasc - Mon Aug 25 00:09:20 2003]:
> 
> > I still need to look more closely at the patch. However I believe the
> > production change feature can now be achieved using the city report
> > dialog. Hence only the unit find feature should require porting.
> > 
> 
> This patch implements the find nearest unit to the map center feature
> for the GTK+ 2.0 client. Please test.
 
I ran the patch and like it but I think that it should find units that are in 
sentry mode as well as inactive. (i.e. change:
    if (punit->type == type) {
      if (punit->focus_status==FOCUS_AVAIL && punit->activity==ACTIVITY_IDLE &&
          punit->moves_left > 0 && !punit->ai.control) {
to:
     if (punit->type == type) {
      if (punit->focus_status==FOCUS_AVAIL && (punit->activity==ACTIVITY_IDLE 
            || punit->activity==ACTIVITY_SENTRY)
          && punit->moves_left > 0 && !punit->ai.control) {




-- 
Josh Cogliati