[Freeciv-Dev] Re: (PR#5431) Unecessary Global Variable in mapgen.c

["rwetmore@xxxxxxxxxxxx" <rwetmore@xxxxxxxxxxxx>]

At one point or place there is/was a comment that explains this is
done to duplicate the logic that is used elsewhere, thus insure the
totalweight is always exactly what is needs to be.

This implies these generator methods are inherently fragile, and
thus I would use caution rather than palate in making any changes.

Cheers,
RossW
=====

Jason Short wrote:
> [cameron - Tue Aug 26 19:41:46 2003]:
[...]
> This code is just amazing:
> 
> -  totalweight= 0;
> -  for (i = game.nplayers; i > 0; i--)
> -    totalweight+= 70;
> -  for (i = game.nplayers; i > 0; i--)
> -    totalweight+= 20;
> -  for (i = game.nplayers; i > 0; i--)
> -    totalweight+= 10;
> +  totalweight = 100 * game.nplayers;
> 
> Is there something I'm missing?  Seems like it's worth a patch all on
> its own.
[...]
> jason