[Freeciv-Dev] Re: (PR#6025) PATCH: reg_gen_for_units

["Per I. Mathisen" <per@xxxxxxxxxxx>]

On Sun, 7 Sep 2003, Marko Lindqvist wrote:
> Per: Can you test if slowdown caused by this is acceptable to you?

Without: user    0m22.490s
With: user    0m22.600s

I'd call that acceptable.

I didn't read the patch, but skimming it very briefly I noticed it would
not pass the coding style comittee.

I got two warnings, too:

gcc -DHAVE_CONFIG_H -I. -I. -I.. -I./../common -I./../ai -I../intl
-I../common/aicore -I./userdb    -g -O2 -Werror -Wall -Wpointer-arith
-Wcast-align -Wmissing-prototypes -Wmissing-declarations -c `test -f
'ruleset.c' || echo './'`ruleset.ccc1: warnings being treated as errors
ruleset.c: In function `req_list_load':
ruleset.c:256: warning: deprecated use of label at end of compound
statement
ruleset.c: In function `load_rulesets':
ruleset.c:2935: warning: unused variable `u'
make[3]: *** [ruleset.o] Error 1

  - Per