[Freeciv-Dev] (PR#5146) Re: Reputation is a fragile thing

["Per I. Mathisen" <per@xxxxxxxxxxx>]

On Mon, 11 Aug 2003, Christian Knoke wrote:
> > I guess the senate toppled you after you declared war without provokation.
> > It should have said: "Game: The senate decides to dissolve rather than
> > support your actions any longer." I am quite surprised if you didn't get
> > this message.
>
> Yes, such a message appear, but only in the chat window, not in the message
> window or popup.

Improvements to messages attached as patch.

> And there is no warning before this happens! There should be, with a chance
> to cancel the diplomatic act.

No, that is point - it is a risk you take when you have Democracy and
Republic. If you declare war (and reputation is lower than perfect), you
might fall into Anarchy.

  - Per

"The truth is there is an ideological struggle between those who believe
that the best way to grow the economy is to give more money to the
wealthy, and the Democrats who believe that the wealthy will make more
money if average people do better." -- Bill Clinton, November 2000

Index: server/plrhand.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/server/plrhand.c,v
retrieving revision 1.288
diff -u -r1.288 plrhand.c
--- server/plrhand.c    19 Aug 2003 19:14:37 -0000      1.288
+++ server/plrhand.c    19 Aug 2003 19:26:59 -0000
@@ -901,8 +901,9 @@
       return;
     }
     remove_shared_vision(pplayer, pplayer2);
-    notify_player(pplayer2, _("%s no longer gives us shared vision!"),
-                pplayer->name);
+    notify_player_ex(pplayer2, -1, -1, E_TREATY_BROKEN,
+                     _("%s no longer gives us shared vision!"),
+                     pplayer->name);
     return;
   }
 
@@ -938,9 +939,10 @@
   if (pplayer->diplstates[pplayer2->player_no].has_reason_to_cancel > 0) {
     pplayer->diplstates[pplayer2->player_no].has_reason_to_cancel = 0;
     if (has_senate && !repeat) {
-      notify_player(pplayer, _("The senate passes your bill because of the "
-                              "constant provocations of the %s."),
-                   get_nation_name_plural(pplayer2->nation));
+      notify_player_ex(pplayer, -1, -1, E_TREATY_BROKEN,
+                       _("The senate passes your bill because of the "
+                         "constant provocations of the %s."),
+                       get_nation_name_plural(pplayer2->nation));
     }
   }
   /* no reason to cancel, apply penalty (and maybe suffer a revolution) */
@@ -949,12 +951,14 @@
      extend the govt rulesets to mimic this -- pt */
   else {
     pplayer->reputation = MAX(pplayer->reputation - reppenalty, 0);
-    notify_player(pplayer, _("Game: Your reputation is now %s."),
-                 reputation_text(pplayer->reputation));
+    notify_player_ex(pplayer, -1, -1, E_TREATY_BROKEN,
+                     _("Game: Your reputation is now %s."),
+                     reputation_text(pplayer->reputation));
     if (has_senate && pplayer->revolution == 0) {
       if (myrand(GAME_MAX_REPUTATION) > pplayer->reputation) {
-       notify_player(pplayer, _("Game: The senate decides to dissolve "
-                                "rather than support your actions any 
longer."));
+        notify_player_ex(pplayer, -1, -1, E_ANARCHY,
+                         _("Game: The senate decides to dissolve "
+                         "rather than support your actions any longer."));
        handle_player_revolution(pplayer);
       }
     }