Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2003:
[Freeciv-Dev] Re: (PR#4815) failed assertion in client goto 		Home

[Freeciv-Dev] Re: (PR#4815) failed assertion in client goto

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: undisclosed-recipients: ;
Subject: [Freeciv-Dev] Re: (PR#4815) failed assertion in client goto
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Mon, 11 Aug 2003 05:54:08 -0700
Reply-to: rt@xxxxxxxxxxxxxx 
Gregory Berkolaiko wrote:
> On Sun, 10 Aug 2003, Jason Short wrote:
> 
> 
>>Jason Short wrote:
>>
>>>Ahh.  They are set to NULL by pft_fill_[default|unit]_parameter.  I 
>>>suppose this means they're always spurious.  But since I don't know why 
>>>they were there in the first place, maybe they should be kept around?
>>
>>Here's a correct version of the patch.
> 
> 
> Actually, I would just kill them.  I am not sure against what they are 
> guarding.

If pft_fill_unit_parameter ever filled in non-NULL values then it's 
likely the goto.c code wouldn't have to add its own values for these 
variables.  In that sense it acts as an alert against for this.

jason
[Prev in Thread] Current Thread [Next in Thread]