[Freeciv-Dev] Re: (PR#4801) can see the whole map when ally dies

["Per I. Mathisen" <per@xxxxxxxxxxx>]

On Sun, 10 Aug 2003, Per I. Mathisen wrote:
> On Sat, 9 Aug 2003, Genevieve Gracian wrote:
> > When one of you ally dies (ai or human), you're able to see the whole
> > map.
>
> The attached patch fixes it. This bug was introduced by my new unit flags
> patch and is not present in S1_14.

And here is the patch.

  - Per

"This is the future for the world we're in at the moment,"
promised Lawrence Di Rita, special assistant to Rumsfeld.
"We'll get better as we do it more often."

Index: server/plrhand.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/server/plrhand.c,v
retrieving revision 1.286
diff -u -r1.286 plrhand.c
--- server/plrhand.c    8 Aug 2003 22:11:42 -0000       1.286
+++ server/plrhand.c    10 Aug 2003 08:30:44 -0000
@@ -195,6 +195,16 @@
 
   pplayer->is_alive = FALSE;
 
+  /* Remove shared vision */
+  players_iterate(aplayer) {
+    if (gives_shared_vision(pplayer, aplayer)) {
+      remove_shared_vision(pplayer, aplayer);
+    }
+    if (gives_shared_vision(aplayer, pplayer)) {
+      remove_shared_vision(aplayer, pplayer);
+    }
+  } players_iterate_end;
+    
   cancel_all_meetings(pplayer);
   map_know_and_see_all(pplayer);
 
@@ -234,13 +244,6 @@
   } city_list_iterate_end;
   game.savepalace = palace;
 
-  players_iterate(aplayer) {
-    /* Remove shared vision */  
-    if (gives_shared_vision(pplayer, aplayer)) {
-      remove_shared_vision(pplayer, aplayer);
-    }
-  } players_iterate_end;
-    
   /* Ensure this dead player doesn't win with a spaceship.
    * Now that would be truly unbelievably dumb - Per */
   spaceship_init(&pplayer->spaceship);