Complete.Org: Mailing Lists: Archives: freeciv-dev: July 2003:
[Freeciv-Dev] Re: (PR#4725) Rename map_get_known and map_get_known_and_s 		Home

[Freeciv-Dev] Re: (PR#4725) Rename map_get_known and map_get_known_and_s

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: andy@xxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#4725) Rename map_get_known and map_get_known_and_seen to map_is_*
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Thu, 31 Jul 2003 08:39:01 -0700
Reply-to: rt@xxxxxxxxxxxxxx 
Andy Smith wrote:

> TODO: perhaps now rename map_get_known2() to map_get_known as the
> name is free?  It seems silly to have a map_get_known2() where
> there is no map_get_known().

IMO this function is a misnomer.  "known" has a well-defined meaning, 
and this isn't it.  It should be map_get_vision_status() or something.

The same is true of tile_get_known.

jason
[Prev in Thread] Current Thread [Next in Thread]