Complete.Org: Mailing Lists: Archives: freeciv-dev: July 2003:
[Freeciv-Dev] (PR#4679) double-tiles
Home

[Freeciv-Dev] (PR#4679) double-tiles

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: undisclosed-recipients: ;
Subject: [Freeciv-Dev] (PR#4679) double-tiles
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Sun, 27 Jul 2003 21:13:15 -0700
Reply-to: rt@xxxxxxxxxxxxxx

[bursig - Fri Jul 25 12:56:20 2003]:

> Dnia 2003.07.25 07:35, Jason Short napisa³(a):
> > 
> > When a tile appears twice on the mapview, it will only be drawn in 
> > one place.  What gets drawn in the other place?  Nothing...which 
> > means the other tile is basically not refreshed and can get cluttered 
> > with stuff like city names, etc.
> > 
> > The attached patch clears the mapview window before redrawing it.
> > 
> > As a side note, we could speed up the full-screen refresh by, in
> > addition to clearing the window before we start to draw tiles, also
> > simply skipping black (unreal/unknown) tiles.  We can do this since
> > they're already drawn black.  But we could only do it in
> > update_map_canvas_visible, not in refresh_tile_mapcanvas.
> > 
> This isn't true becouse you only win when have lot of unreal/unknown 
> terrains (at start) but later it only much slow down drawing (depend of 
> screen resolution).

True.  And in any case it's unlikely we would use this optimization, so
the patch just slows down drawing (by an unmeasured, but probably very
small, amount).  So the question is: is this worth it for the minor bugfix?

jason



[Prev in Thread] Current Thread [Next in Thread]