[Freeciv-Dev] (PR#4672) more uninitialized AI values

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

pcity->ai.wallvalue is not initialized when we reload a saved game either:

==13971== Conditional jump or move depends on uninitialised value(s)
==13971==    at 0x80CCE7D: assess_defense_quadratic (advmilitary.c:179)
==13971==    by 0x80DAAF8: look_for_charge (aiunit.c:1596)
==13971==    by 0x80DB051: ai_military_findjob (aiunit.c:1729)
==13971==    by 0x80DE360: ai_manage_military (aiunit.c:2748)
==13971==    by 0x80DEA9D: ai_manage_units (aiunit.c:2898)
==13971==    by 0x804E4F8: ai_start_turn (srv_main.c:436)
==13971==    by 0x804FE16: main_loop (srv_main.c:1442)
==13971==    by 0x80502F4: srv_main (srv_main.c:1588)
==13971==    by 0x804A007: main (civserver.c:154)
==13971==    by 0x403A04EC: __libc_start_main (in /lib/libc-2.3.2.so)
==13971==    by 0x8049C60: (within /tmp/jshort/freeciv/server/civserver)
==13971==
==13971== Conditional jump or move depends on uninitialised value(s)
==13971==    at 0x80CCE98: assess_defense_quadratic (advmilitary.c:180)
==13971==    by 0x80DAAF8: look_for_charge (aiunit.c:1596)
==13971==    by 0x80DB051: ai_military_findjob (aiunit.c:1729)
==13971==    by 0x80DE360: ai_manage_military (aiunit.c:2748)
==13971==    by 0x80DEA9D: ai_manage_units (aiunit.c:2898)
==13971==    by 0x804E4F8: ai_start_turn (srv_main.c:436)
==13971==    by 0x804FE16: main_loop (srv_main.c:1442)
==13971==    by 0x80502F4: srv_main (srv_main.c:1588)
==13971==    by 0x804A007: main (civserver.c:154)
==13971==    by 0x403A04EC: __libc_start_main (in /lib/libc-2.3.2.so)
==13971==    by 0x8049C60: (within /tmp/jshort/freeciv/server/civserver)

I'm not sure what the line 180 means.


Also there's this one:

==13971== Conditional jump or move depends on uninitialised value(s)
==13971==    at 0x80D82A3: stay_and_defend (aiunit.c:791)
==13971==    by 0x80DD00C: ai_military_attack (aiunit.c:2354)
==13971==    by 0x80DE438: ai_manage_military (aiunit.c:2759)
==13971==    by 0x80DEA9D: ai_manage_units (aiunit.c:2898)
==13971==    by 0x804E4F8: ai_start_turn (srv_main.c:436)
==13971==    by 0x804FE16: main_loop (srv_main.c:1442)
==13971==    by 0x80502F4: srv_main (srv_main.c:1588)
==13971==    by 0x804A007: main (civserver.c:154)
==13971==    by 0x403A04EC: __libc_start_main (in /lib/libc-2.3.2.so)
==13971==    by 0x8049C60: (within /tmp/jshort/freeciv/server/civserver)

jason