[Freeciv-Dev] Re: Connect Dialog Patch, version 7 (ready?) (PR#4638)

["ChrisK@xxxxxxxx" <ChrisK@xxxxxxxx>]

Daniel Speyer wrote:

> Christian Knoke wrote:

> > civclient -t trident -P none -a
> > gives segfault.
> > 
> 
> Fixed, though I wonder if the whole -a tag needs re-examining.

This works bad. -a option gives stale civservers and allows two connections
from one client. It should IMHO do the following:

1) try to connect to an _existing_ civserver

2) when this fails, give message and startup as if -a option had not been
   given.

> > GUI issues
> > ----------
> > 
> > There needs to be a way to translate the options. While it may be
> > acceptable to use the server option names (instead of more descriptive
> > names) for them in the english version, this is certainly not acceptable
> > for L10n.
> 
> Hmm.  We don't AFAICT *have* translated server options.  Anyone who
> plays freeciv with options now needs to use the pseudo-english names.
> At least the help information is translated.

I let this for now. Something needs to be done here.

> > Top left globe grafics vanishes and never reappears.

> This is an old and unrelated problem.

Never seen this before. But ok.

> > Not possible to set ongoing options before the game starts (segfault)

> I can't reproduce that.  What circumstances are you under?

When I load a game, nothing happens when I call 'Ongoing options' in
pregame. When I call after the game has started, the client segfaults.

More serious problems:

I get stale civservers, when I finish civclient by closing the window or
pressing Alt-F4

------

GLib-CRITICAL **: file gmain.c: line 500 (g_source_remove): assertion `tag >
0' failed.
<<close_connection_dialog>>

GLib-CRITICAL **: file gmain.c: line 500 (g_source_remove): assertion `tag >
0' failed.
<<close_connection_dialog>>
<<close_connection_dialog>>

------

Gtk-WARNING **: invalid cast from `(unknown)' to `GtkObject'

Gtk-CRITICAL **: file gtkobject.c: line 1080 (gtk_object_get_data):
assertion `GTK_IS_OBJECT (object)' failed.

Gtk-WARNING **: invalid cast from `GtkDirectionType' to `GtkObject'
    
Gtk-CRITICAL **: file gtkobject.c: line 1080 (gtk_object_get_data):
assertion `GTK_IS_OBJECT (object)' failed.

-----

Once I opened the option window and got:

#0  0x080ad8b1 in change_server_options (opts=0x837d69e "") at
repodlgs.c:1235
1235      }else if (GTK_IS_WINDOW(permwin[pregame_flag]) &&
GTK_WIDGET_VISIBLE(permwin[pregame_flag])){
(gdb) bt
#0  0x080ad8b1 in change_server_options (opts=0x837d69e "") at
repodlgs.c:1235
#1  0x08074c70 in handle_page_msg (packet=0x837d350) at packhand.c:822
#2  0x08065f99 in handle_packet_input (packet=0x837d350, type=42) at  
civclient.c:320
#3  0x08069473 in input_from_server (fd=6) at clinet.c:343
#4  0x0809c442 in get_net_input (data=0x0, fid=6, condition=GDK_INPUT_READ)
    at gui_main.c:1172
#5  0x40194934 in gdk_io_invoke () from /usr/lib/libgdk-1.2.so.0
#6  0x401c63b0 in g_io_unix_dispatch () from /usr/lib/libglib-1.2.so.0
#7  0x401c7c46 in g_main_dispatch () from /usr/lib/libglib-1.2.so.0   
#8  0x401c8273 in g_main_iterate () from /usr/lib/libglib-1.2.so.0    
#9  0x401c843c in g_main_run () from /usr/lib/libglib-1.2.so.0
#10 0x400e076c in gtk_main () from /usr/lib/libgtk-1.2.so.0   
#11 0x0809beee in ui_main (argc=1, argv=0xbffff624) at gui_main.c:988
#12 0x08065e7f in main (argc=5, argv=0xbffff624) at civclient.c:247  
#13 0x4034e7ee in __libc_start_main () from /lib/libc.so.6

--------

Another point: Can you use $USER as the user name, not "Owner"? Looks very
strange.

--------

> > GUI suggestions
> > ---------------
> > 
> > Enable/Disable set and reset buttons accordingly, when options are
> > changed. It is not obvious, that you have to use "set", to apply the
> > modified options to the game.

> Strikes me as a bad idea, though I do see your point.  Reset is also the
> way to read in other players' changes, so that should be enabled in any
> case.  That makes enabling/disabling set rather ugly.

Ok.

> Maybe we can come up with something better.

We'll see.

> > There should be an interface to use the server mechanism of
> > saveturn/savename to save games.

> Done (they now appear in the ongoing options dialog)

Yes, but the savename is not used when I save :-(  Also, when I use "save
game as", and forget input a name, it saves under '.gz'. I know this is
difficult, so don't mind.

Christian

-- 
Christian Knoke     * * *      http://www.enter.de/~c.knoke/
* * * * * * * * *  Ceterum censeo Microsoft esse dividendum.